[Mlir-commits] [mlir] merge code for llvm.emit_c_interface into convertFuncOpToLLVMFuncOp (PR #92986)

[Oleksandr Alex Zinenko]

https://github.com/ftynse requested changes to this pull request.

Thanks for the patch! I suppose this is the case of "nobody needed this yet".

Can we do one step further and actually generalize this function to be usable without conversion patterns? It can take a `RewriterBase &` instead of `ConversionPatternRewriter` as far as I can see. Then it becomes usable standalone and the test can be simplified to actually test the function and not the function + conversion infra.

https://github.com/llvm/llvm-project/pull/92986