[Mlir-commits] [mlir] [mlir][SCF] Deprecate `linalg::tileToForallOp` and `linalg::tileToForallOpUsingTileSizes` (PR #91878)

[llvmlistbot at llvm.org]

MaheshRavishankar wrote:

> > Can you provide some information about what transformations need the num threads information that cannot be derived when needed (like just getting the number of iterations of the loop)
> 
> Not immediately as this is out of my immediate working memory but TL;DR:
> 
> * logic to reinfer number of threads from IR and in particular 1-trip count loop etc is extremely brittle as soon as things don't trivially divide. IIRC it may be quite brittle even in cases that things divide but do not quote me on this
> * tile dynamic sized ops by dynamic adaptive tile sizes and things become even more hairy
> * rediscovering a static number of threads after we threw the information away is not worth it

@nicolasvasilache  I think I got a handle on what was done, and this was a good pointer. Most of the test pass, there area only a few corner case lit tests that are failing for me locally (CI says something else, I need to triage that), but this is ready for review.

https://github.com/llvm/llvm-project/pull/91878