[Mlir-commits] [mlir] [mlir][polynomial] use typed attributes for polynomial.constant op (PR #92818)

[Mehdi Amini]

================
@@ -286,10 +286,10 @@ def Polynomial_ConstantOp : Op<Polynomial_Dialect, "constant", [Pure]> {
     ```mlir
     #poly = #polynomial.int_polynomial<x**1024 - 1>
     #ring = #polynomial.ring<coefficientType=i32, coefficientModulus=65536:i32, polynomialModulus=#poly>
-    %0 = polynomial.constant #polynomial.int_polynomial<1 + x**2> : !polynomial.polynomial<#ring>
+    %0 = polynomial.constant {value=#polynomial.int_polynomial<1 + x**2>} : !polynomial.polynomial<#ring>
----------------
joker-eph wrote:

If you only support int and float, you could have a short form:
```
%0 = polynomial.constant int<1 + x**2> : !polynomial.polynomial<ring=...>
```
(or any keyword instead of `int`/`float`)

https://github.com/llvm/llvm-project/pull/92818