[Mlir-commits] [mlir] [mlir][emitc] Support scalar MemRef types (PR #92684)

[Matthias Gehre]

mgehre-amd wrote:

I'm not convinced that this is the canonical way to handle rank-0 memrefs. For example, when you have a rank-0 memref as function argument and then the function body writes into it, you cannot turn the argument into a scalar.

There are alternative ways to lower this (e.g. promoting rank-0 memrefs to rank-1), so this doesn't seem to be the canonical choice.

Converting rank-0 memrefs to scalars sounds like a transform that is not specific to emitc, so I'm more in favor of having this as a separate transform (in the memref dialect) instead if merging it into the memref-to-emitc conversion pass.

https://github.com/llvm/llvm-project/pull/92684