[Mlir-commits] [mlir] [mlir][polynomial] fix polynomial.constant syntax in docstrings (PR #92818)
Mehdi Amini
llvmlistbot at llvm.org
Mon May 20 13:52:37 PDT 2024
================
@@ -286,10 +286,10 @@ def Polynomial_ConstantOp : Op<Polynomial_Dialect, "constant", [Pure]> {
```mlir
#poly = #polynomial.int_polynomial<x**1024 - 1>
#ring = #polynomial.ring<coefficientType=i32, coefficientModulus=65536:i32, polynomialModulus=#poly>
- %0 = polynomial.constant #polynomial.int_polynomial<1 + x**2> : !polynomial.polynomial<#ring>
+ %0 = polynomial.constant {value=#polynomial.int_polynomial<1 + x**2>} : !polynomial.polynomial<#ring>
----------------
joker-eph wrote:
This is a bit obnoxious: can we mimic arith.constant instead?
Also we should never let properties being printed in the attribute dictionary as a good practice, so either add prop-dict or list the attributes explicitly in the assembly format. (I should close this loop-hole in the infra, but that'll be a bad breaking change)
https://github.com/llvm/llvm-project/pull/92818
More information about the Mlir-commits
mailing list