[Mlir-commits] [mlir] [mlir][python] Add bindings for mlirDenseElementsAttrGet (PR #91389)

Stella Laurenzo llvmlistbot at llvm.org
Mon May 20 13:13:04 PDT 2024


https://github.com/stellaraccident commented:

In general, you're getting push back because the original authors deeply regret DenseElementsAttr for most cases, having switched most cases that matter to DenseArrayAttr (for "normal" inline values) or DenseResourceAttr for bulk storage. In general, the attribute elements approach has cost many dearly in terms of compile time and overhead. So it's a little confusing thinking about enabling that further. 

With that said, I don't think what you are proposing hurts anything. I'd probably draw the line if it required C API changes as not being worth it.

https://github.com/llvm/llvm-project/pull/91389


More information about the Mlir-commits mailing list