[Mlir-commits] [mlir] [mlir][bufferization] Fix OneShotBufferize when `defaultMemorySpaceFn` is used (PR #91524)

Matthias Springer llvmlistbot at llvm.org
Mon May 20 03:36:00 PDT 2024


matthias-springer wrote:

> Can you add extra unit tests for `scf.for` (with tensor iter_arg that has an encoding), `scf.if` and `scf.execute_region` (with tensor result). I think these bufferization pattern must be updated because they create new `to_tensor` ops.

Ideally, to make this PR not even larger, if an update to these patterns is indeed needed, you could update those patterns in a first, separate PR. I think not much has to change, you just have to take the tensor types from the input IR instead of inferring them in the op builder.


https://github.com/llvm/llvm-project/pull/91524


More information about the Mlir-commits mailing list