[Mlir-commits] [mlir] [MLIR][Python] add ctype python binding support for bf16 (PR #92489)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Sat May 18 03:47:24 PDT 2024


xurui1995 wrote:

> I think adding it to the project requirements with a note about it being optional is fine, as then the upstream CI will test it. But the code path itself should be optional. This API gets integrated in a bunch of places, and it is those leaves which specify concrete deps for their case. The local requirements file is just for upstream.

Hi, @stellaraccident thanks for your review.
I'd like to add `ml_dtypes` in `requirements.txt` with a note and keep `try...except` in `np_to_memref.py`, but I have a question about the new bf16 test case in`mlir/test/python/execution_engine.py`, after adding `ml_dtypes` in `requirements.txt`, should we assume that ml_dtypes is installed by default, or should this test case also be considered as part of the code path and need a `try...except`?

https://github.com/llvm/llvm-project/pull/92489


More information about the Mlir-commits mailing list