[Mlir-commits] [mlir] [mlir] [Dialect] Add LibC dialect and printf op for CPU (PR #92369)

[Renato Golin]

https://github.com/rengolin commented:

FWIW, we already have some [printing primitives](https://github.com/llvm/llvm-project/blob/main/mlir/include/mlir/ExecutionEngine/RunnerUtils.h).

I don't mind adding `printf`, but adding a whole dialect just for this opens a dialect discussion that is far wider than this one function.

* Can we add this to the existing primitives?
* Do we need a whole `libc` dialect? Perhaps c++ too?
* Will this help Clang with CIL? Do they already have something like this?

I'd suggest you try the easy route with the current primitives and see what that gets you.

Some nits on the code. Also, your tests are not enough. You need to cover the functionality you add, including the error messages that you expect to get on a _negative_ test.

https://github.com/llvm/llvm-project/pull/92369