[Mlir-commits] [mlir] [MLIR][Vector] Fix transferOps optimization inside maskOp (PR #90835)

[Andrzej Warzyński]

banach-space wrote:

Sorry, I missed your reply!

> I have submitted :
> 
> * [[MLIR][Vector] Implement transferXXPermutationLowering as MaskableOpRewritePattern #91987](https://github.com/llvm/llvm-project/pull/91987) for `TransferReadPermutationLowering`,  `TransferWritePermutationLowering` and `TransferWriteNonPermutationLowering`
> * [[MLIR][Vector] Implement TransferReadOfExtractSliceOp as MaskableOpRewritePattern #91960](https://github.com/llvm/llvm-project/pull/91960)  targetting  `TransferReadOfExtractSliceOpFolder`.

I think that you can land these? Do you have commit access?

> * I have a branch ready to be pushed on top of them to address `TransferOpReduceRank`.

Nice!

> * I can reuse this PR to merge `Transfer{Read|write}ToVector{Load|store}Lowering` or create another one if you think it is a better practice.

I would create a new PR. Otherwise this discussion will look disconnected from the actual PR. But there are no hard rules, I'm still trying to figure out the "canonical GitHub way" 😅 

https://github.com/llvm/llvm-project/pull/90835