[Mlir-commits] [mlir] [mlir][SPIRV] Add support for dense_resource in arith to spirv (PR #91318)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Wed May 15 07:06:29 PDT 2024
================
@@ -229,16 +230,29 @@ struct ConstantCompositeOpPattern final
if (!srcType || srcType.getNumElements() == 1)
return failure();
- // arith.constant should only have vector or tenor types.
+ // arith.constant should only have vector or tensor types.
assert((isa<VectorType, RankedTensorType>(srcType)));
----------------
maxbartel wrote:
Good questions, there are TODOs all over MLIR to disallow other types, but at the moment almost everything is allowed. I emit a failure now.
https://github.com/llvm/llvm-project/pull/91318
More information about the Mlir-commits
mailing list