[Mlir-commits] [mlir] [mlir][vector] Teach `TransferOptimization` to forward masked stores (PR #87794)

Benjamin Maxwell llvmlistbot at llvm.org
Wed May 15 06:57:56 PDT 2024


================
@@ -170,12 +170,43 @@ AffineMap mlir::vector::getTransferMinorIdentityMap(ShapedType shapedType,
       shapedType.getContext());
 }
 
+/// Returns true if the value written by `defWrite` could be the same as the
+/// value read by `read`. Note: True is 'could be' not 'definitely' (as this
+/// simply looks at the masks and the value written). For a definite answer use
+/// `checkSameValueRAW()` -- which calls this function.
----------------
MacDue wrote:

The comments inside the function explain what it checks, so I don't think those need to be duplicated (since this is a static function it won't be publicly visible outside of `VectorOps.cpp`).

https://github.com/llvm/llvm-project/pull/87794


More information about the Mlir-commits mailing list