[Mlir-commits] [mlir] [mlir][linalg] Add linalg.conv_2d_ngchw_gfchw_q to named ops (PR #92136)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Tue May 14 13:16:21 PDT 2024


zjgarvey wrote:


> It should generate the current file. If there are discrepancies, please consider sending a separate patch so we can examine what they are and advise.

Will do.

> A roundtripping test showing that the op exists can can be parsed and printed back, and a test that converts this op to a generic op to check the correctness of the model and guard against regression in the specification. Both are FileCheck tests.

I think I added the types of lit tests you were talking about. Please let me know if those look appropriate. 

> Also please note that the first message of the PR is being picked up as commit description and update it to something more meaningful.

Changed, thanks!

https://github.com/llvm/llvm-project/pull/92136


More information about the Mlir-commits mailing list