[Mlir-commits] [mlir] Reimplementing target description concept using DLTI attribute (PR #92138)

Oleksandr Alex Zinenko llvmlistbot at llvm.org
Tue May 14 12:05:36 PDT 2024


https://github.com/ftynse requested changes to this pull request.

Thanks! This generally goes in the right direction, let's iterate on this.

One large comment: this needs standalone tests for the target description part. For the existing DLTI part, we have a test pass that looks at certain kinds of ops and/or attributes and "interprets" them as requests to the data layout object, the results of these requests are appended back to ops as more attributes that we can FileCheck on. Something similar should be possible here.

https://github.com/llvm/llvm-project/pull/92138


More information about the Mlir-commits mailing list