[Mlir-commits] [mlir] [mlir][linalg] Add linalg.conv_2d_ngchw_gfchw_q to named ops (PR #92136)

[Oleksandr Alex Zinenko]

ftynse wrote:

> For future reference, is bin/update_core_linalg_named_ops.sh supposed to regenerate the current yaml file exactly? If not, is the general practice to run this script and revert any unrelated diffs manually?

It should generate the current file. If there are discrepancies, please consider sending a separate patch so we can examine what they are and advise.

> I'm not sure what kinds of unit tests would be appropriate for simply adding a new op like this. Any suggestions?

A roundtripping test showing that the op exists can can be parsed and printed back, and a test that converts this op to a generic op to check the correctness of the model and guard against regression in the specification. Both are FileCheck tests.

Also please note that the first message of the PR is being picked up as commit description and update it to something more meaningful.

https://github.com/llvm/llvm-project/pull/92136