[Mlir-commits] [mlir] [MLIR][LLVM] add dwarfAddressSpace to DIDerivedType (PR #92043)

Tobias Gysi llvmlistbot at llvm.org
Mon May 13 23:12:40 PDT 2024


gysit wrote:

> Note that I'm not really sure what to do about the C API. One option is to use a signed type and turn negative values into std::nullopt.

I am not super familiar with the C API and I didn't see any prior art modeling an std::nullopt. I guess your current solution makes sense if 0 = std::nullopt in all cases with practical relevance. If we need to make a difference, the solution with a signed integer and some constant that represents std::nullopt maybe better.

https://github.com/llvm/llvm-project/pull/92043


More information about the Mlir-commits mailing list