[Mlir-commits] [mlir] [MLIR][LLVM] add dwarfAddressSpace to DIDerivedType (PR #92043)

[Christian Ulmann]

================
@@ -418,6 +418,7 @@ def LLVM_DIDerivedTypeAttr : LLVM_Attr<"DIDerivedType", "di_derived_type",
     OptionalParameter<"uint64_t">:$sizeInBits,
     OptionalParameter<"uint32_t">:$alignInBits,
     OptionalParameter<"uint64_t">:$offsetInBits,
+    OptionalParameter<"std::optional<unsigned>">:$dwarfAddressSpace,
----------------
Dinistro wrote:

Modeling this as an optional optional seems a bit odd. Do you know if there is a sematnic difference between zero and `std::nullopt`? If there is none, it would be nicer to model this as `OptionalParameter<"uint32_t">`.

https://github.com/llvm/llvm-project/pull/92043