[Mlir-commits] [mlir] [mlir][vector] Split `TransposeOpLowering` into 2 patterns (PR #91935)

[Benjamin Maxwell]

MacDue wrote:

> > > I think such a change causes failure on SPIR-V backend.
> > 
> > 
> > It shouldn't, this is merely moving code around.
> 
> IIRC this is now going to be generating a vector.shape_cast that isnt handled on SPIR-V backends, and this pattern is being added to a "generic vector lowering" pattern set. I'd suggest adding a "populateVectorTransposeLoweringForLLVMPatterns" and adding this to that path. I know the SPIR-V path isnt tested as well in MLIR, but the shape_cast isnt supported on SPIR-V path.

IIRC this lowering has not been a problem on SPIR-V for a while now (since `populateVectorShapeCastLoweringPatterns()` is now called in the IREE SPIR-V backend). We removed any option to disable this lowering as it was not needed for SPIR-V (see #75062). 

https://github.com/llvm/llvm-project/pull/91935