[Mlir-commits] [mlir] [MLIR][JitRunner] Correctly register symbol map (PR #90381)

[Ingo Müller]

ingomueller-net wrote:

> [...] `engine->registerSymbols(runtimeSymbolMap)` is indeed called in `ExecutionEngine::create`. However, `mlir::JitRunnerMain` has its own `runtimeSymbolMap` passed by the argument `JitRunnerConfig config`. But if you track the dataflow of `JitRunnerConfig::runtimeSymbolMap`, you will find that it is never passed to an `ExecutionEngine`. So `JitRunnerConfig::runtimeSymbolMap` given by the user is never used in `mlir::JitRunnerMain`.

I think I understand now. Inside the local definitions of `runtimeSymbolMap`, before the commit, it said:

```c++
auto symbolMap = config.runtimeSymbolMap ? config.runtimeSymbolMap(interner)
                                         : llvm::orc::SymbolMap();
```

whereas, after the commit, in the new location, it says:

```c++
auto symbolMap = llvm::orc::SymbolMap();
```

I do not remember right now any rationale for this change, so I suppose it was introduced by accident.

https://github.com/llvm/llvm-project/pull/90381