[Mlir-commits] [clang] [clang-tools-extra] [flang] [llvm] [mlir] [polly] [test]: fix filecheck annotation typos (PR #91854)
    Tom Eccles 
    llvmlistbot at llvm.org
       
    Mon May 13 06:20:11 PDT 2024
    
    
  
https://github.com/tblah commented:
Thank you for the cleanup!
Two of the flang tests don't pass. Please could you remove all of the changed CHECK lines in `flang/Lower/array.f90` and `flang/Lower/module_use.f90`.
`array.f90` seems to have always been broken: `CHECK-LABEL` is enforcing an unreliable ordering of elements within the top level MLIR Module. This doesn't work correctly because the FIR globals are output after the func.func.
The checks in `module_use.f90` are double commented and under a TODO, so I think they were never meant to run.
Both tests verify an old flang lowering path which is deprecated.
CC @clementval 
https://github.com/llvm/llvm-project/pull/91854
    
    
More information about the Mlir-commits
mailing list