[Mlir-commits] [mlir] [mlir][SPIRV] Add support for dense_resource in arith to spirv (PR #91318)

Kunwar Grover llvmlistbot at llvm.org
Fri May 10 08:31:37 PDT 2024


================
@@ -229,16 +230,29 @@ struct ConstantCompositeOpPattern final
     if (!srcType || srcType.getNumElements() == 1)
       return failure();
 
-    // arith.constant should only have vector or tenor types.
+    // arith.constant should only have vector or tensor types.
     assert((isa<VectorType, RankedTensorType>(srcType)));
----------------
Groverkss wrote:

Is this the only supported case or is this the only possible case? Can you clarify this in the comment? If this is the only supported case, let's emit a failure with a nice error message instead.

https://github.com/llvm/llvm-project/pull/91318


More information about the Mlir-commits mailing list