[Mlir-commits] [mlir] [MLIR][JitRunner] Correctly register symbol map (PR #90381)

Ingo Müller llvmlistbot at llvm.org
Fri May 10 04:57:40 PDT 2024


ingomueller-net wrote:

> @banach-space @ingomueller-net Hi, would you please help to review this PR? Thanks!
> 
> I have noticed that commit [0b3841eb97f5c7951c2375e5b1a38ea89d9d6a37](https://github.com/llvm/llvm-project/commit/0b3841eb97f5c7951c2375e5b1a38ea89d9d6a37) removed the call to `engine->registerSymbols(runtimeSymbolMap);`. Was it on purpose or was removed accidentally?

I can't provide much insight about the big picture but I want to point out that the call to `registerSymbols` wasn't removed completely but moved to (the end of) `ExecutionEngine::create`.

https://github.com/llvm/llvm-project/pull/90381


More information about the Mlir-commits mailing list