[Mlir-commits] [mlir] [MLIR][Vector] Fix transferOps optimization inside maskOp (PR #90835)

[Andrzej Warzyński]

https://github.com/banach-space commented:

Thanks for the updates, looks good!

I've noticed that the following patterns have been updated:
* `TransferReadOfExtractSliceOpFolder`
* `TransferReadPermutationLowering`
* `TransferWritePermutationLowering`
* `TransferWriteNonPermutationLowering`
* `TransferOpReduceRank`
* `TransferReadToVectorLoadLowering`
* `TransferWriteToVectorStoreLowering`

However, there's only 3 new tests :) And it's hard to tell which tests corresponds to which pattern. You could address that by creating multiple PRs and group similar patterns together (e.g. `TransferReadToVectorLoadLowering` and `TransferWriteToVectorStoreLowering`). Just a loose suggestion, not a requirement.

In any case, it would be good to see new tests for every of these patterns. In particular, if a pattern doesn't support masking, we should still be able to test that. 

https://github.com/llvm/llvm-project/pull/90835