[Mlir-commits] [mlir] [mlir] [linalg] Check for dim shape to decide unit dim for each operand in dropUnitDims pass. (PR #91673)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Thu May 9 16:39:02 PDT 2024


https://github.com/MaheshRavishankar requested changes to this pull request.

I The real issue here is that if `d0` is unit-dim in one operand, any use of `d0` to access any other dim has to be unit-dim as well (by constructions). Really we should be calling these linalg ops illegal.
I think we have a way to make sure the dimensions match for Linalg ops. Will try to find those.

https://github.com/llvm/llvm-project/pull/91673


More information about the Mlir-commits mailing list