[Mlir-commits] [mlir] [MLIR][OpenMP] NFC: Remove redundant check (PR #91594)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Thu May 9 06:48:07 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-mlir
Author: Sergio Afonso (skatrak)
<details>
<summary>Changes</summary>
The check removed by this patch in the OpenMP to LLVM IR translation pass already exists as part of the op verifier for `omp.loop_nest`.
---
Full diff: https://github.com/llvm/llvm-project/pull/91594.diff
1 Files Affected:
- (modified) mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp (-4)
``````````diff
diff --git a/mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp b/mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
index bfd7d65912bdb..69ad18f84c783 100644
--- a/mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
+++ b/mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
@@ -925,10 +925,6 @@ convertOmpWsloop(Operation &opInst, llvm::IRBuilderBase &builder,
auto loopOp = cast<omp::LoopNestOp>(wsloopOp.getWrappedLoop());
const bool isByRef = wsloopOp.getByref();
- // TODO: this should be in the op verifier instead.
- if (loopOp.getLowerBound().empty())
- return failure();
-
// Static is the default.
auto schedule =
wsloopOp.getScheduleVal().value_or(omp::ClauseScheduleKind::Static);
``````````
</details>
https://github.com/llvm/llvm-project/pull/91594
More information about the Mlir-commits
mailing list