[Mlir-commits] [mlir] [MLIR][Interfaces] Change MemorySlotInterface to use OpBuilder (PR #91341)

[Matthias Springer]

matthias-springer wrote:

A rewriter is essentially a builder with extra API. So I am surprised that switching from `RewriterBase` to `OpBuilder` made any difference.

> I've talked to multiple people that complained about the rewriter not being able to properly deal with block arguments.

What kind of functionality/API is missing?

> This is an issue, as it leads to the invalidation of the dominance information

How does this relate to dominance information? Either you modify the IR in such a way that dominance info is invalidated or not; whether you use a rewriter or a builder should not matter.


https://github.com/llvm/llvm-project/pull/91341