[Mlir-commits] [mlir] Support polynomial attributes with floating point coefficients (PR #91137)

Mehdi Amini llvmlistbot at llvm.org
Tue May 7 20:34:10 PDT 2024


================
@@ -149,7 +172,7 @@ def Polynomial_PolynomialType : Polynomial_Type<"Polynomial", "polynomial"> {
     A type for polynomials in a polynomial quotient ring.
   }];
   let parameters = (ins Polynomial_RingAttr:$ring);
-  let assemblyFormat = "`<` $ring `>`";
+  let assemblyFormat = "`<` qualified($ring) `>`";
----------------
joker-eph wrote:

Isn't `#polynomial.ring` just pure noise here though? Seems a bit obnoxious to me to read the full expanded form.

Why not `!polynomial.polynomial<ring<coefficientType = f32>>` then?

https://github.com/llvm/llvm-project/pull/91137


More information about the Mlir-commits mailing list