[Mlir-commits] [mlir] [mlir][tensor] Remove assertion in ExpandShapeOp::build (PR #91361)

Benoit Jacob llvmlistbot at llvm.org
Tue May 7 11:00:39 PDT 2024


bjacob wrote:

Actually there is another problem: this condition in C++ builder code is impossible to exercise from `mlir` source in tensor dialect, as omitting `output_shape` is a parsing error. It can only be exercised from C++. The bad caller here is a C++ caller. Its source is ultimately MLIR, but in TOSA dialect. So if we added a MLIR test, it would have to be in TOSA dialect.

https://github.com/llvm/llvm-project/pull/91361


More information about the Mlir-commits mailing list