[Mlir-commits] [mlir] [mlir][tensor] Remove assertion in ExpandShapeOp::build (PR #91361)

Benoit Jacob llvmlistbot at llvm.org
Tue May 7 10:48:07 PDT 2024


bjacob wrote:

as a follow-up please :-) need to unblock the downstreams.

also, the test would ideally test for a helpful error message, which runs into a problem i had writing this PR: I dont know how if it's safe to call `emitOpError` before the end of `build()`. I didn't want to take any chances with unblocking the integrates.

So +1 to a follow-up that finds how to generate a helpful error , and tests that.

https://github.com/llvm/llvm-project/pull/91361


More information about the Mlir-commits mailing list