[Mlir-commits] [mlir] [OpenMP][MLIR] Add `private` clause to `omp.target` (PR #91202)

Sergio Afonso llvmlistbot at llvm.org
Mon May 6 08:07:43 PDT 2024


================
@@ -469,14 +469,18 @@ ParseResult parseClauseWithRegionArgs(
 static void printClauseWithRegionArgs(OpAsmPrinter &p, Operation *op,
                                       ValueRange argsSubrange,
                                       StringRef clauseName, ValueRange operands,
-                                      TypeRange types, ArrayAttr symbols) {
-  p << clauseName << "(";
+                                      TypeRange types, ArrayAttr symbols,
+                                      bool printPrefixSuffix = true) {
+  if (printPrefixSuffix)
+    p << clauseName << "(";
----------------
skatrak wrote:

What do you think about skipping printing the "clauseName(" and ")" when `!clauseName` rather than adding a new bool argument? And then just pass `nullptr` from `printPrivateList`.

https://github.com/llvm/llvm-project/pull/91202


More information about the Mlir-commits mailing list