[Mlir-commits] [mlir] [MLIR][EmitC] Don't translate expressions inline if user is `emitc.subscript` (PR #91087)

[Simon Camphausen]

================
@@ -210,3 +210,18 @@ func.func @expression_with_address_taken(%arg0: i32, %arg1: i32, %arg2: !emitc.p
   }
   return %c : i1
 }
+
+// CPP-DEFAULT: int32_t expression_with_subscript_user(void* [[VAL_1:v.+]])
+// CPP-DEFAULT-NEXT:   int64_t [[VAL_2:v.+]] = 0;
+// CPP-DEFAULT-NEXT:   int32_t* [[VAL_3:v.+]] = (int32_t*) [[VAL_1]];
+// CPP-DEFAULT-NEXT:   return [[VAL_3]]{{\[}}[[VAL_2]]{{\]}};
----------------
simon-camp wrote:

nit: We use triple brackets in other places where we subscript by captured values.

```suggestion
// CPP-DEFAULT-NEXT:   return [[VAL_3]][[[VAL_2]]];
```

https://github.com/llvm/llvm-project/pull/91087