[Mlir-commits] [mlir] [mlir][arith] Fix overflow bug in arith::CeilDivSIOp::fold (PR #90947)

[Mehdi Amini]

joker-eph wrote:

>  Just wondering if you could point out where in the codebase is the constant folder called duirng conversion?

Constant folding is always involved by the dialect conversion framework implicitly.

> Perhaps an extra integration test, consisting of an end-to-end run of the original file with arith-expand or convert-arith-to-llvm pass, would give a bit further assurance or this patch?

This shouldn't be needed: when we root cause the problem we focus on unit-testing instead. 


https://github.com/llvm/llvm-project/pull/90947