[Mlir-commits] [mlir] [mlir][transform] Add support for transform.param pad multiples in `PadOp` (PR #90755)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Wed May 1 22:46:38 PDT 2024


================
@@ -1021,8 +1023,7 @@ def PadOp : Op<Transform_Dialect, "structured.pad",
                       TransformHandleTypeInterface:$pad,
                       TransformHandleTypeInterface:$copy);
 
-  let assemblyFormat =
-    "$target attr-dict `:` functional-type(operands, results)";
+  let hasCustomAssemblyFormat = 1;
----------------
MaheshRavishankar wrote:

I dont know about the transform ops, but the ops that implement the `ViewLikeInterface` use the custom parser/printer hooks for handling this (https://github.com/llvm/llvm-project/blob/b86e0992bfa6c58be077d82d824016f590ac5d90/mlir/include/mlir/Interfaces/ViewLikeInterface.h#L107) . Maybe that could be refactored a little bit to allow using that without needing the op to implement the interface. AFAIK, those dont have this problem.

https://github.com/llvm/llvm-project/pull/90755


More information about the Mlir-commits mailing list