[Mlir-commits] [mlir] [mlir][linalg] Vectorize unpack op without masking (PR #89067)

Andrzej WarzyƄski llvmlistbot at llvm.org
Wed May 1 03:17:31 PDT 2024


================
@@ -1547,7 +1559,9 @@ vectorizeAsTensorPackOp(RewriterBase &rewriter, tensor::PackOp packOp,
 ///   vector::TransposeOp - Transpose the Source tensor
 ///   ShapeCastOp - Reshape the data based on the target.
 ///   vector::TransferWriteOp. - Write the result vector back to the destination
-///   tensor
+///   tensor. If the vector sizes are not provided, then the vector sizes are
+///   determined by the result tensor shape. In case the vector sizes aren't
+///   provided, we update the inBounds attribute instead of masking.
----------------
banach-space wrote:

Fix duplication ("vector sizes are not provided"):
```suggestion
///   tensor. If the vector sizes are not provided:
//      * the vector sizes are determined by the result tensor shape,
//      * update the inBounds attribute instead of masking.
```

https://github.com/llvm/llvm-project/pull/89067


More information about the Mlir-commits mailing list