[Mlir-commits] [mlir] [MLIR][Arith] Add rounding mode attribute to `truncf` (PR #86152)

Jakub Kuderski llvmlistbot at llvm.org
Fri Mar 29 08:17:59 PDT 2024


================
@@ -28,6 +28,31 @@ using namespace mlir;
 
 namespace {
 
+/// Operations whose conversion will depend on whether they are passed a
+/// rounding mode attribute or not.
+///
+/// \tparam SourceOp is the source operation; \tparam TargetOp, the operation it
+/// will lower to; \tparam AttrConvert is the attribute conversion to convert
+/// the rounding mode attribute.
----------------
kuhar wrote:

nit: We tend to use markdown for comments in mlir, I see '// `SourceOp` is the ...' much more frequently

https://github.com/llvm/llvm-project/pull/86152


More information about the Mlir-commits mailing list