[Mlir-commits] [mlir] [mlir][linalg] Enable fuse consumer (PR #85528)

[llvmlistbot at llvm.org]

https://github.com/MaheshRavishankar requested changes to this pull request.

Thanks for the changes. I looked at the changes to the `TilingInterface`... those look good. Just left a few nits.

I missed this, but could you instead look at the implementation in https://github.com/llvm/llvm-project/blob/main/mlir/lib/Dialect/SCF/Transforms/TileUsingInterface.cpp instead. That file does tile consumer and fuse producer using the `LoopLikeOpInterface` and works for both `scf.for` and `scf.forall`. The path that is here in `LinalgTransforms` is supposed to be deprecated (by me when I get some time). Last time I touched it, I made things fairly modular and readable (afaik) and just following that but instead fusing with consumers would be a great help. If added here, it will just be on my list of things to deprecate and move it to the above file anyway.

I havent looked at the `LinalgTransforms.*` changes (cause I am also not an expert in transform dialect). I think it would be better to make these methods available outside of transform dialect to be callable as standalone utility functions (like is done in the implementation I linked to above).

https://github.com/llvm/llvm-project/pull/85528