[Mlir-commits] [mlir] [mlir] Add the concept of ASM dialect aliases (PR #86033)

Markus Böck llvmlistbot at llvm.org
Thu Mar 28 09:56:17 PDT 2024


zero9178 wrote:

> You're correct the lookup itself wouldn't kill performance, as it is equivalent to `cast, isa...`, however, searching through the vector does have the potential to kill performance.
> 
> Maybe, we agree that that's the price to use aliases, and that in general users shouldn't use many. However, that's a design decision we need to make.

It certainly would be the price if someone were to register thousands of aliases. But we're getting side tracked here, I think the interface variant is fine and if you prefer it then let's go with that. 

https://github.com/llvm/llvm-project/pull/86033


More information about the Mlir-commits mailing list