[Mlir-commits] [mlir] [mlir][test] Make SME e2e tests require an emulator (PR #86489)

Mehdi Amini llvmlistbot at llvm.org
Wed Mar 27 17:00:56 PDT 2024


joker-eph wrote:

I don't quite get the proposal, what is the meaning of LLVM_TARGET_ARCH_FEATURES?

It does not seem to provide value to me to do so, it seems to me that the user is already explicit with `-DMLIR_RUN_ARM_SME_TESTS=ON`, so I can see the value of detecting that something is missing to be able to run the tests and provide a good diagnostic to the user, but I can't quite see how asking the user to provide another extra flag is useful.

https://github.com/llvm/llvm-project/pull/86489


More information about the Mlir-commits mailing list