[Mlir-commits] [mlir] [mlir] Add `requiresVisitingMutatedDefs` and `visitMutatedDefs` to `PromotableOpInterface` (PR #86792)

Christian Ulmann llvmlistbot at llvm.org
Wed Mar 27 06:44:57 PDT 2024


Dinistro wrote:

> > Maybe add a test with two dbg value ops on the same store to determine that this works as intended.
> 
> Are you referring to a test with two dbg declare ops? Because this change should only affect `llvm.dbg.declare`. Also, It's worth noting that after the change all existing tests passed.

Sorry for the confusion, yes, I meant two dbg declares. 

I'm currently working on extensions for both SROA and Mem2Reg, and I can tell you that the test coverage is unfortunately not sufficient for such cases.

https://github.com/llvm/llvm-project/pull/86792


More information about the Mlir-commits mailing list