[Mlir-commits] [mlir] [mlir][test] Make SME e2e tests require an emulator (PR #86489)

[Mehdi Amini]

joker-eph wrote:

> No lines is better than 3

This does not seem like a useful comment IMO.

A nice error message at configuration time is much better than a compile time failure, which is itself much better than a link-time failure, which itself is much better than a runtime test failure!

There is much more than "3 lines" in terms of complexity that exists in MLIR as safeguard against user mis-configuration.
For example detecting creation of operation or attribute when the dialect isn't loaded, or more recently the whole "promised" interfaces: 
https://github.com/llvm/llvm-project/blob/80487e1c622d51f4c0df12b64cca8a0b346e9b85/mlir/include/mlir/IR/OpDefinition.h#L2062-L2068
(same code exists in other places)
Leading to: https://github.com/llvm/llvm-project/blob/80487e1c622d51f4c0df12b64cca8a0b346e9b85/mlir/include/mlir/IR/Dialect.h#L231-L243

> I've seen setups in the past for example where emulation is enabled opaquely via binfmt_misc on Linux.

That seems like a valid use-case, @banach-space how do you see this supported?
Also: what about someone who has the actual HW in the future?


https://github.com/llvm/llvm-project/pull/86489