[Mlir-commits] [mlir] [mlir] Declare promised interfaces for all dialects (PR #78368)

[Mehdi Amini]

================
@@ -69,6 +71,10 @@ void ControlFlowDialect::initialize() {
       >();
   addInterfaces<ControlFlowInlinerInterface>();
   declarePromisedInterface<ControlFlowDialect, ConvertToLLVMPatternInterface>();
+  declarePromisedInterfaces<bufferization::BufferizableOpInterface, BranchOp,
+                            CondBranchOp>();
+  declarePromisedInterface<CondBranchOp,
+                           bufferization::BufferDeallocationOpInterface>();
----------------
joker-eph wrote:

>From the backtrace, the crash you have seems actually a good showcase for "incorrect setup" detected by the promise right? You're using the bufferization interface but "forgot" to register the extension for the CF dialect as far as I can tell.


https://github.com/llvm/llvm-project/pull/78368