[Mlir-commits] [mlir] [mlir][test] Make SME e2e tests require an emulator (PR #86489)

[Cullen Rhodes]

c-rhodes wrote:

> > Who is this change for? I don't see why we need to do anything here, if anything
> 
> This is for anyone who'd like to try the SME e2e tests in MLIR :) The intention is to document things better - both through "actual" documentation and config scripts (with the latest version, CMake will complain if you set `MLIR_RUN_ARM_SME_TESTS` but keep `ARM_EMULATOR_EXECUTABLE` empty).

I think this is introducing unnecessary guardrails that aren't required to try the e2e tests. I would think it's pretty obvious an emulator is required when a user hits SIGILLs when trying to run the tests and that's reason enough that this isn't required, but this is also removing an option other users may want. I've seen setups in the past for example where emulation is enabled opaquely via binfmt_misc on Linux.

> 
> > this is creating work for our future selves
> 
> I'm happy to address any future issues that this may bring 😅 Also, it's just 3 lines of CMake.

No lines is better than 3

https://github.com/llvm/llvm-project/pull/86489