[Mlir-commits] [mlir] 5d18789 - [mlir][inliner] Return early if the inliningThreshold is 0U or -1U. (#86287)

[llvmlistbot at llvm.org]

Author: Fabian Tschopp
Date: 2024-03-23T00:09:11+01:00
New Revision: 5d187898f625cc54310f51b278b36ad6a97104ee

URL: https://github.com/llvm/llvm-project/commit/5d187898f625cc54310f51b278b36ad6a97104ee
DIFF: https://github.com/llvm/llvm-project/commit/5d187898f625cc54310f51b278b36ad6a97104ee.diff

LOG: [mlir][inliner] Return early if the inliningThreshold is 0U or -1U. (#86287)

Computing the inlinling profitability can be costly due to walking the
graph when counting the number of operations.

This PR addresses that by returning early if the threshold is set to
never or always inline.

Added: 
    

Modified: 
    mlir/lib/Transforms/InlinerPass.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Transforms/InlinerPass.cpp b/mlir/lib/Transforms/InlinerPass.cpp
index 08d8dbf73a6a1d..9a7d5403a95dc5 100644
--- a/mlir/lib/Transforms/InlinerPass.cpp
+++ b/mlir/lib/Transforms/InlinerPass.cpp
@@ -93,12 +93,19 @@ InlinerPass::InlinerPass(std::function<void(OpPassManager &)> defaultPipeline,
 // Return true if the inlining ratio does not exceed the threshold.
 static bool isProfitableToInline(const Inliner::ResolvedCall &resolvedCall,
                                  unsigned inliningThreshold) {
+  // Return early, ratio <= 0U will always be false.
+  if (inliningThreshold == 0U)
+    return false;
+  // Return early, ratio <= -1U will always be true.
+  if (inliningThreshold == -1U)
+    return true;
+
   Region *callerRegion = resolvedCall.sourceNode->getCallableRegion();
   Region *calleeRegion = resolvedCall.targetNode->getCallableRegion();
 
   // We should not get external nodes here, but just return true
   // for now to preserve the original behavior of the inliner pass.
-  if (!calleeRegion || !calleeRegion)
+  if (!callerRegion || !calleeRegion)
     return true;
 
   auto countOps = [](Region *region) {