[Mlir-commits] [mlir] [mlir][EmitC] Add support for pointer and opaque types to subscript op (PR #86266)

[Matthias Gehre]

================
@@ -63,7 +63,8 @@ struct ConvertLoad final : public OpConversionPattern<memref::LoadOp> {
     }
 
     auto subscript = rewriter.create<emitc::SubscriptOp>(
-        op.getLoc(), operands.getMemref(), operands.getIndices());
+        op.getLoc(), cast<TypedValue<emitc::ArrayType>>(operands.getMemref()),
----------------
mgehre-amd wrote:

Can we allow the builder to take `Value` and leave the verification to the verifier? This is currently more verbose to write, and when it fails it would assert instead of being a verifier error.

https://github.com/llvm/llvm-project/pull/86266