[Mlir-commits] [mlir] e1f50fd - [mlir] Remove unused and untested `shouldSplitInputFile`. (#85622)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Fri Mar 22 05:35:41 PDT 2024


Author: Ingo Müller
Date: 2024-03-22T13:35:36+01:00
New Revision: e1f50fdc03efecb5da39c1df4fc08d2ce5da90e9

URL: https://github.com/llvm/llvm-project/commit/e1f50fdc03efecb5da39c1df4fc08d2ce5da90e9
DIFF: https://github.com/llvm/llvm-project/commit/e1f50fdc03efecb5da39c1df4fc08d2ce5da90e9.diff

LOG: [mlir] Remove unused and untested `shouldSplitInputFile`. (#85622)

This was changed by #84765 but turned out to be buggy. Since it isn't
used and isn't tested, it is probably best to remove it.

Added: 
    

Modified: 
    mlir/include/mlir/Tools/mlir-opt/MlirOptMain.h

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Tools/mlir-opt/MlirOptMain.h b/mlir/include/mlir/Tools/mlir-opt/MlirOptMain.h
index 8adc80908de116..4f7f83cdb47376 100644
--- a/mlir/include/mlir/Tools/mlir-opt/MlirOptMain.h
+++ b/mlir/include/mlir/Tools/mlir-opt/MlirOptMain.h
@@ -144,7 +144,6 @@ class MlirOptMainConfig {
     splitInputFileFlag = std::move(splitMarker);
     return *this;
   }
-  bool shouldSplitInputFile() const { return splitInputFileFlag.empty(); }
   StringRef inputSplitMarker() const { return splitInputFileFlag; }
 
   /// Set whether to merge the output chunks into one file using the given


        


More information about the Mlir-commits mailing list