[Mlir-commits] [mlir] [mlir][transform] Emit error message with `emitSilenceableFailure` (PR #86146)

Oleksandr Alex Zinenko llvmlistbot at llvm.org
Fri Mar 22 03:57:44 PDT 2024


ftynse wrote:

> @ftynse As a general rule of thumb, should i even bother waiting for the windows buildkite to finish? often it just hangs for several hours, other times it just fails for reasons irrelevant to the PR, and rarely does it actually finish and pass (for me at least)

Use your best judgement and be ready to revert if submitting before it passes. I usually wait when changing the build system (Windows/MSVC tends to catch missing dependencies) or ABI-impacting things, but may not wait otherwise. 10 hours is an overkill, but it did pass this time.

https://github.com/llvm/llvm-project/pull/86146


More information about the Mlir-commits mailing list