[Mlir-commits] [mlir] Fix unsupported transpose ops for scalable vectors in LowerVectorTransfer (PR #86163)
Benjamin Maxwell
llvmlistbot at llvm.org
Fri Mar 22 03:57:56 PDT 2024
================
@@ -201,12 +205,19 @@ struct TransferWritePermutationLowering
// Generate new transfer_write operation.
Value newVec = rewriter.create<vector::TransposeOp>(
op.getLoc(), op.getVector(), indices);
+
+ auto vectorType = cast<VectorType>(newVec.getType());
+
+ if (vectorType.isScalable() && !*vectorType.getScalableDims().end()) {
----------------
MacDue wrote:
Btw, for this check there's `isLegalVectorType()` here: https://github.com/llvm/llvm-project/blob/main/mlir/lib/Dialect/ArmSME/Transforms/VectorLegalization.cpp#L421-L430
Maybe this could be moved to some general utils?
https://github.com/llvm/llvm-project/pull/86163
More information about the Mlir-commits
mailing list