[Mlir-commits] [mlir] [mlir][arith] Refine the verifier for arith.constant (PR #86178)
Jakub Kuderski
llvmlistbot at llvm.org
Thu Mar 21 14:17:04 PDT 2024
================
@@ -190,6 +190,14 @@ LogicalResult arith::ConstantOp::verify() {
return emitOpError(
"value must be an integer, float, or elements attribute");
}
+
+ // Intializing scalable vectors with elements attribute is not supported
+ // unless it's a vector splot.
+ auto vecType = dyn_cast<VectorType>(type);
+ auto val = dyn_cast<DenseElementsAttr>(getValue());
+ if ((vecType && val) && vecType.isScalable() && !val.isSplat())
----------------
kuhar wrote:
nit: you can simplify this a bit
```suggestion
if (vecType && vecType.isScalable() && !isa<SplatElementsAttr>(getValue()))
```
https://github.com/llvm/llvm-project/pull/86178
More information about the Mlir-commits
mailing list