[Mlir-commits] [mlir] [mlir][transform] Fix failure in flattening already flattened linalg ops (PR #86037)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Thu Mar 21 08:49:04 PDT 2024


================
@@ -3269,15 +3269,20 @@ DiagnosedSilenceableFailure transform::FlattenElementwiseLinalgOp::applyToOne(
     transform::ApplyToEachResultList &results,
     transform::TransformState &state) {
   rewriter.setInsertionPoint(target);
-  if (target.getNumLoops() <= 1)
+  if (!isElementwise(target)) {
+    failed(rewriter.notifyMatchFailure(
+        target, "only elementwise flattening is supported"));
+    return emitDefaultSilenceableFailure(target);
----------------
srcarroll wrote:

Sorry, I'm new to the transform framework and still learning how things work. I was just following another implementation in this same file for the message. I'll submit another PR to fix.

About tagging you.  I made an RFC for this per your suggestion with a mention to the original PR and Mahesh was the only one that took any action so I just went with him again for this.  I'll be sure to include you in the future.

https://github.com/llvm/llvm-project/pull/86037


More information about the Mlir-commits mailing list