[Mlir-commits] [mlir] [mlir][emitc] Fix form-expressions inside expression (PR #86081)

Marius Brehler llvmlistbot at llvm.org
Thu Mar 21 06:37:11 PDT 2024


marbre wrote:

> `--` as in git-send-email workflow, so everything below is a personal note for reviewer, which doesn't belong to commit.

Ah, I am not familiar with that tool :) But makes sense. I normally only add what I want in my squash commit message to the PR description. For everything else, I add an additional comment. But that's due to the GitHub workflow...

> I try to have commit messages correct/make sense, though you can also extend/reword if you feel like it.

No need to, your explanation makes sense and also providing an additional note is perfectly fine.

https://github.com/llvm/llvm-project/pull/86081


More information about the Mlir-commits mailing list